This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Fix secure properties not loaded in daemon mode #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## next #701 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 193 193
Lines 9907 9908 +1
Branches 1877 1878 +1
=======================================
+ Hits 8580 8581 +1
Misses 1322 1322
Partials 5 5
Continue to review full report at Codecov.
|
|
All tests are passing, but for some reason the GitHub workflows that run on Windows are failing to archive test result artifacts? |
awharn
approved these changes
Dec 9, 2021
Seems that uploading folders as artifacts fails on Windows, when there is an empty file present: actions/upload-artifact#281 |
gejohnston
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes zowe/zowe-cli#1232 by loading secure properties inside
Config.reload