Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string comparison (use != instead of is not) #41

Merged
merged 1 commit into from Dec 30, 2019
Merged

Fix string comparison (use != instead of is not) #41

merged 1 commit into from Dec 30, 2019

Commits on Dec 25, 2019

  1. Fix string comparison (use != instead of is not) 

    Python 3.8 gives a warning for us in `zope/sqlalchemy/datamanager.py:132`:
SyntaxWarning: "is not" with a literal. Did you mean "!="?

That warning seems correct, and the `is not` might even lead to unintended results. So this line should probably be changed to `!=` .
    @martinstein
    martinstein committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    51209a9 View commit details
    Browse the repository at this point in the history