Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string comparison (use != instead of is not) #41

Merged
merged 1 commit into from Dec 30, 2019
Merged

Fix string comparison (use != instead of is not) #41

merged 1 commit into from Dec 30, 2019

Conversation

martinstein
Copy link
Contributor

@martinstein martinstein commented Dec 25, 2019

Python 3.8 gives a warning for us in zope/sqlalchemy/datamanager.py:132:

SyntaxWarning: "is not" with a literal. Did you mean "!="?

That warning seems correct, and the is not might even lead to unintended results. So this line should probably be changed to != .

Python 3.8 gives a warning for us in `zope/sqlalchemy/datamanager.py:132`:
SyntaxWarning: "is not" with a literal. Did you mean "!="?

That warning seems correct, and the `is not` might even lead to unintended results. So this line should probably be changed to `!=` .
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

If you haven't already, this might need you to sign the Plone Foundation contributor agreement, after which you'll be able to merge this PR yourself.

@martinstein
Copy link
Contributor Author

Good to hear. Can this be merged without the whole Contributor Agreement? I'd say the proposed change is so small that it can be considered a "minor change" according to the Policy for Contributor Agreements ( https://plone.org/foundation/materials/foundation-resolutions/patch-policy-052011 ). They mention as minor fixes:

Correcting typographic errors such as incorrect identifiers, operators, punctuation or white space;

and the PR simply corrects an operator, so it should be fine.

@mgedmin mgedmin merged commit b2227a3 into zopefoundation:master Dec 30, 2019
@mgedmin
Copy link
Member

mgedmin commented Dec 30, 2019

Yeah, the change looks too trivial to be copyrightable, so I'm going to just merge this.

Thank you!

@martinstein martinstein deleted the patch-1 branch January 1, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants