Run tests on GHA. #37
Conversation
|
CI seems to be broken because of actions/setup-python#171. |
|
Appveyor seems to need a 3.9 wheel of |
|
Using an older actions/setup-python to get GHA running again. |
| python3.7 | ||
| commands = | ||
| coverage run -m zope.testrunner --test-path=src [] | ||
| coverage report --fail-under=100 |
There was a problem hiding this comment.
We had 100%, and now we have 99%? What happened?
There was a problem hiding this comment.
It's mostly branch coverage (which we had disabled before), but also now line 109 in src/zope/sendmail/maildir.py is no longer covered.
zope.sendmail/src/zope/sendmail/maildir.py
Line 109 in 5e3f786
This appears to be a side effect of switching from basepython = python3.7 to basepython = python3 (which is 3.8 on my Ubuntu 20.10)!
Anyway, this is fine, we can climb back to 100% later.
Appveyor has a C compiler and shouldn't need any wheels. The error
seems to indicate that our appevyor.yml is missing a |
Just to see what happens. If this works, we'll want to update the appveyor.yml template in zopefoundation/meta.
|
zopefoundation/meta#54 adds wheel to the appveyor.yml template. |
The bug which inspired this workaround was fixed. Co-authored-by: Marius Gedminas <marius@gedmin.as>
|
Yes, let's. |
No description provided.