Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm64 wheel #219

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

odidev
Copy link
Collaborator

@odidev odidev commented Oct 5, 2020

Added support for arm64 wheel development.
Modified .manylinux-install.sh to add tox support for arm64.

Related to #214
@jamadden Please review.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except the tox command-line is too convoluted and for no good reason.

tox supports -e py which means "use the same python version that tox itself is running under".

if [ `uname -m` == 'aarch64' ]; then
cd /io/
"${PYBIN}/pip" install tox
"${PYBIN}/python" -m tox -e py`echo "${PYBIN}" | cut -f 4 -d"/" | cut -f 1 -d"-" | cut -c3-`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified to

Suggested change
"${PYBIN}/python" -m tox -e py`echo "${PYBIN}" | cut -f 4 -d"/" | cut -f 1 -d"-" | cut -c3-`
"${PYBIN}/tox" -e py

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgedmin Thank you for the feedback.
I have done the changes as suggested by you. Please check.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@icemac
Copy link
Member

icemac commented Oct 12, 2020

@odidev Thank you for your contribution.

According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change before it can be merged. For details please consult the Contributing guidelines for zopefoundation projects.

@odidev
Copy link
Collaborator Author

odidev commented Nov 4, 2020

@icemac, I have signed the CLA. Could you please merge the changes?

@icemac
Copy link
Member

icemac commented Nov 4, 2020

@odidev As you are a member of the GitHub organization now, you should be able to merge the PR yourself.

@odidev odidev merged commit db372a6 into zopefoundation:master Nov 5, 2020
@icemac
Copy link
Member

icemac commented Nov 5, 2020

@odidev Thank you for your contribution. Do you need a new release of this package so arm64 wheels get built?

@odidev
Copy link
Collaborator Author

odidev commented Nov 5, 2020

@icemac Thanks for the quick response. Yes, releasing AArch64 wheels would be really helpful for AArch64 users.

@icemac
Copy link
Member

icemac commented Nov 5, 2020

Let's add Python 3.9 support in #222 and then cut a release.

@icemac
Copy link
Member

icemac commented Nov 5, 2020

@icemac
Copy link
Member

icemac commented Nov 5, 2020

It might take some minutes until the wheels are uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants