test: Convert tests to ESM and upgrade Chai #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed by removing |
eatyourgreens
commented
Jan 11, 2024
test/index.mjs
Outdated
Comment on lines
27
to
31
| global.chai = { | ||
| ...baseChai, | ||
| ...baseChai.use(chaiAsPromised), | ||
| ...baseChai.use(chaiHttp), | ||
| ...baseChai.use(chaiSpies), | ||
| ...baseChai.use(chaiChanges) | ||
| }; |
There was a problem hiding this comment.
This is a workaround for chaijs/chai#1569, because imports are immutable.
eatyourgreens
force-pushed
the
esm-tests
branch
3 times, most recently
from
f31ae89
to
e147b77
Compare
eatyourgreens
force-pushed
the
esm-tests
branch
from
e147b77
to
eead64b
Compare
Convert all the tests to ESM (`.mjs`) in preparation for Chai 5, which drops support for CommonJS.
- replace `require` with `import` throughout.
- create a global `chai` object to replace the old `chai = require('chai')`.
- rename tests from '.js' to '.mjs'.
eatyourgreens
force-pushed
the
esm-tests
branch
from
eead64b
to
e9efdbd
Compare
eatyourgreens
force-pushed
the
esm-tests
branch
from
ea8c18f
to
b6f6f85
Compare
eatyourgreens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all the tests to ESM (
.mjs) in preparation for Chai 5, which drops support for CommonJS.requirewithimportthroughout.chaiobject to replace the oldchai = require('chai')..jsto.mjs.chai-httpandchai-as-promised, which aren't being used by any tests.chaiv5.1.0.