Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack-dev-server dependencies #6438

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Feb 23, 2023

Reinstall webpack-dev-server, to force an upgrade of its dependencies. Node 18 is crashing because of a crashing bug in memfs 3.4.1, which is a dependency of webpack-dev-middleware.

Staging branch URL: https://pr-6438.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

Reinstall `webpack-dev-server`, to force an upgrade of its dependencies and fix a crashing bug in `memfs` 3.4.1 on Node 18.
@coveralls
Copy link

Coverage Status

Coverage: 57.422% (+0.004%) from 57.418% when pulling 95a3d7f on upgrade-dev-server into c0d1906 on master.

@mcbouslog mcbouslog self-assigned this Feb 24, 2023
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As noted in Slack removing host: process.env.HOST || 'localhost' from webpack.dev.js is required to run PFE locally (one of PR review checklist items).

@eatyourgreens eatyourgreens merged commit f5f2c67 into master Feb 24, 2023
@eatyourgreens eatyourgreens deleted the upgrade-dev-server branch February 24, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants