Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Puma Worker Killer based on requests count #80

Closed

Conversation

ylecuyer
Copy link
Contributor

@ylecuyer ylecuyer commented Jan 25, 2020

This is a proof of concept based on puma/puma#2106
It mimics the PassengerMaxRequests configuration of passenger : https://www.phusionpassenger.com/library/config/apache/reference/#passengermaxrequests and kills workers after 10k requests

Here is a demo: https://youtu.be/ZUho9KCQGXk

@schneems
Copy link
Member

Can you tell me more about the desire here? I think this can be implemented better as a separate middleware. Basically in the middleware you can simply exit(1) or raise a sigterm in the existing process, then puma will bring it back up. My preference would be to not add this directly to puma worker killer. If you make another gem, then I can link it in the README.

@schneems schneems closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants