Feature sasl plain #1873
Open
Feature sasl plain #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
+ Coverage 43.26% 43.41% +0.14%
==========================================
Files 122 123 +1
Lines 32384 32586 +202
Branches 33 33
==========================================
+ Hits 14012 14148 +136
- Misses 18347 18413 +66
Partials 25 25
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| SCString ssOfferCaps; | ||
| for (const auto& it : m_mCoreCaps) { | ||
| bool bServerDependent = std::get<0>(it.second); | ||
| if (!bServerDependent || | ||
| m_ssServerDependentCaps.count(it.first) > 0) | ||
| m_ssServerDependentCaps.count(it.first) > 0) { | ||
| if (it.first.Equals("sasl") && iCapVersion >= 302) { |
There was a problem hiding this comment.
Why is sasl server-dependent?
| PutClient(":irc.znc.in 904 " + GetNick() + " :SASL response too long"); | ||
| SASLReset(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Could you reformat the code? It's hard to read and I don't understand what's going on
| @@ -469,6 +469,15 @@ def IsClientCapSupported(self, pClient, sCap, bState): | |||
| def OnClientCapRequest(self, pClient, sCap, bState): | |||
| pass | |||
|
|
|||
| def OnGetSASLMechanisms(self, ssMechanisms): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #1573:
Feel free to squash when merging