Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict DELPORT to non-active ports only #1808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

csprr
Copy link
Contributor

@csprr csprr commented Aug 20, 2021

Possible fix (if wanted) for issue #1806
In "danger" of locking yourself out by removing your active port, this should not be possible (same as to HTTP) in my opinion.

Possible fix (if wanted) for issue znc#1806 
In "danger" of locking yourself out by removing your active port, this should not be possible (same as to HTTP) in my opinion.
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1808 (a15ebc5) into master (9cd3605) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
- Coverage   41.34%   41.26%   -0.09%     
==========================================
  Files         122      122              
  Lines       27578    27581       +3     
  Branches       33       33              
==========================================
- Hits        11402    11380      -22     
- Misses      16151    16176      +25     
  Partials       25       25              
Impacted Files Coverage Δ
src/ClientCommand.cpp 11.22% <0.00%> (-0.90%) ⬇️
include/znc/Utils.h 65.95% <0.00%> (-6.39%) ⬇️
src/main.cpp 45.37% <0.00%> (-1.20%) ⬇️
src/Threads.cpp 88.75% <0.00%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd3605...a15ebc5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant