Skip to content

Commit

Permalink
drop unicorn/better-regex because of a conflict with other rules
Browse files Browse the repository at this point in the history
  • Loading branch information
zloirock committed Jun 9, 2021
1 parent 1aea2f3 commit b553358
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .eslintrc.js
Expand Up @@ -365,8 +365,6 @@ const base = {
strict: ['error', 'global'],

// unicorn
// enforce the use of regex shorthands to improve readability
'unicorn/better-regex': 'error',
// enforce a specific parameter name in catch clauses
'unicorn/catch-error-name': ['error', { name: 'error', ignore: [/^err/] }],
// enforce passing a message value when throwing a built-in error
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/es.regexp.flags.js
@@ -1,4 +1,4 @@
/* eslint-disable unicorn/better-regex, regexp/sort-flags, regexp/no-useless-flag -- required for testing */
/* eslint-disable regexp/sort-flags, regexp/no-useless-flag -- required for testing */
import { DESCRIPTORS } from '../helpers/constants';

if (DESCRIPTORS) {
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/es.regexp.to-string.js
@@ -1,4 +1,4 @@
/* eslint-disable unicorn/better-regex, regexp/sort-flags, regexp/no-useless-flag -- required for testing */
/* eslint-disable regexp/sort-flags, regexp/no-useless-flag -- required for testing */
import { STRICT } from '../helpers/constants';

QUnit.test('RegExp#toString', assert => {
Expand Down

0 comments on commit b553358

Please sign in to comment.