ignore NodeJS in IS_BROWSER detection to avoid a false positive wit…

…h `jsdom`, #1110
zloirock · Jul 28, 2022 · a52a60a · a52a60a
1 parent 43a054a
commit a52a60a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## Changelog
 ##### Unreleased
+- NodeJS is ignored in `IS_BROWSER` detection to avoid a false positive with `jsdom`, [#1110](https://github.com/zloirock/core-js/issues/1110)
 - Fixed detection of `@@species` support in `Promise` in some old engines
 - `{ Array, %TypedArray% }.prototype.{ findLast, findLastIndex }` marked as shipped [in FF104](https://bugzilla.mozilla.org/show_bug.cgi?id=1775026)
 - Added iOS Safari 15.6 compat data mapping

diff --git a/packages/core-js/internals/engine-is-browser.js b/packages/core-js/internals/engine-is-browser.js
@@ -1 +1,6 @@
-module.exports = typeof window == 'object' && typeof Deno != 'object';
+var IS_DENO = require('../internals/engine-is-deno');
+var IS_NODE = require('../internals/engine-is-node');
+
+module.exports = !IS_DENO && !IS_NODE
+  && typeof window == 'object'
+  && window.document && document.nodeType === 9;