replace broken URL constructor in Safari, close #656

zloirock · Oct 2, 2019 · 8699b9a · 8699b9a
1 parent 4d12e15
commit 8699b9a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -37,8 +37,9 @@
 - Updated `Map#upsert` [stage 1 proposal](https://github.com/thumbsupep/proposal-upsert)
   - `Map#updateOrInsert` renamed to `Map#upsert`
   - Added `WeakMap#upsert`
-- Added a workaround for iOS Safari MessageChannel + bfcache bug, [#624](https://github.com/zloirock/core-js/issues/624) 
-- Added a workaround for Chrome 33 / Android 4.4.4 `Promise` bug, [#640](https://github.com/zloirock/core-js/issues/640) 
+- Added a workaround for iOS Safari MessageChannel + bfcache bug, [#624](https://github.com/zloirock/core-js/issues/624)
+- Added a workaround for Chrome 33 / Android 4.4.4 `Promise` bug, [#640](https://github.com/zloirock/core-js/issues/640)
+- Replaced broken `URL` constructor in Safari, [#656](https://github.com/zloirock/core-js/issues/656)
 - Added compat data for Node to 12.11, FF 69 and Phantom 1.9
 - `Math.hypot` marked as not supported in Chrome 77 since [a bug in this method](https://bugs.chromium.org/p/v8/issues/detail?id=9546) was not fixed before the stable Chrome 77 release
 - Fixed unnecessary exposing on `Symbol.matchAll` in `esnext.string.match-all`, [#626](https://github.com/zloirock/core-js/issues/626)

diff --git a/packages/core-js-compat/src/data.js b/packages/core-js-compat/src/data.js
@@ -1472,13 +1472,11 @@ const data = {
     chrome: '71',
     node: '10.0',
     firefox: '57',
-    safari: '12.0',
   },
   'web.url-search-params': {
     chrome: '63',
     node: '10.0',
     firefox: '57',
-    safari: '12.0',
   },
 };
 

diff --git a/packages/core-js/internals/native-url.js b/packages/core-js/internals/native-url.js
@@ -20,5 +20,7 @@ module.exports = !fails(function () {
     // not punycoded in Edge
     || new URL('http://тест').host !== 'xn--e1aybc'
     // not escaped in Chrome 62-
-    || new URL('http://a#б').hash !== '#%D0%B1';
+    || new URL('http://a#б').hash !== '#%D0%B1'
+    // throws in Safari
+    || new URL('http://x', undefined).host !== 'x';
 });
diff --git a/tests/compat/tests.js b/tests/compat/tests.js
@@ -48,7 +48,8 @@ var URL_AND_URL_SEARCH_PARAMS_SUPPORT = function () {
     && new URL('https://a@b').username === 'a'
     && new URLSearchParams(new URLSearchParams('a=b')).get('a') === 'b'
     && new URL('http://тест').host === 'xn--e1aybc'
-    && new URL('http://a#б').hash === '#%D0%B1';
+    && new URL('http://a#б').hash === '#%D0%B1'
+    && new URL('http://x', undefined).host === 'x';
 };
 
 var OBJECT_PROTOTYPE_ACCESSORS_SUPPORT = function () {