update eslint-plugin-unicorn

zloirock · Jun 2, 2021 · 7d3200c · 7d3200c
1 parent 4580cef
commit 7d3200c
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -403,6 +403,10 @@ const base = {
   'unicorn/prefer-string-slice': 'error',
   // prefer `switch` over multiple `else-if`
   'unicorn/prefer-switch': ['error', { minimumCases: 3 }],
+  // enforce using the separator argument with `Array#join()`
+  'unicorn/require-array-join-separator': 'error',
+  // enforce using the digits argument with `Number#toFixed()`
+  'unicorn/require-number-to-fixed-digits-argument': 'error',
 
   // sonarjs
   // merging collapsible if statements increases the code's readability

diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
     "eslint-plugin-qunit": "^6.1.1",
     "eslint-plugin-regexp": "~0.11.0",
     "eslint-plugin-sonarjs": "~0.7.0",
-    "eslint-plugin-unicorn": "^32.0.1",
+    "eslint-plugin-unicorn": "^33.0.0",
     "glob": "^7.1.7",
     "jsonc-eslint-parser": "^1.0.1",
     "karma": "^6.3.3",

diff --git a/tests/compat/tests.js b/tests/compat/tests.js
@@ -317,7 +317,7 @@ GLOBAL.tests = {
       return false;
     }
     try {
-      Array.prototype.join.call(null);
+      Array.prototype.join.call(null, '');
       return false;
     } catch (error) { /* empty */ }
     return true;

diff --git a/tests/pure/esnext.set.join.js b/tests/pure/esnext.set.join.js
@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/require-array-join-separator -- required for testing */
 import Set from 'core-js-pure/features/set';
 
 QUnit.test('Set#join', assert => {

diff --git a/tests/tests/es.number.to-fixed.js b/tests/tests/es.number.to-fixed.js
@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/require-number-to-fixed-digits-argument -- required for testing */
 QUnit.test('Number#toFixed', assert => {
   const { toFixed } = Number.prototype;
   assert.isFunction(toFixed);

diff --git a/tests/tests/es.typed-array.join.js b/tests/tests/es.typed-array.join.js
@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/require-array-join-separator -- required for testing */
 import { DESCRIPTORS, GLOBAL, TYPED_ARRAYS } from '../helpers/constants';
 
 if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.join', assert => {

diff --git a/tests/tests/esnext.set.join.js b/tests/tests/esnext.set.join.js
@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/require-array-join-separator -- required for testing */
 QUnit.test('Set#join', assert => {
   const { join } = Set.prototype;