RangeError on NaN in .drop and .take

tc39/proposal-iterator-helpers#181
zloirock · Jul 24, 2022 · 4540e90 · 4540e90
1 parent d078d00
commit 4540e90
Show file tree

Hide file tree

Showing 13 changed files with 27 additions and 8 deletions.
diff --git a/packages/core-js/internals/not-a-nan.js b/packages/core-js/internals/not-a-nan.js
@@ -0,0 +1,7 @@
+var $RangeError = RangeError;
+
+module.exports = function (it) {
+  // eslint-disable-next-line no-self-compare -- NaN check
+  if (it === it) return it;
+  throw $RangeError('NaN is not allowed');
+};
diff --git a/packages/core-js/modules/esnext.async-iterator.drop.js b/packages/core-js/modules/esnext.async-iterator.drop.js
@@ -4,6 +4,7 @@ var $ = require('../internals/export');
 var apply = require('../internals/function-apply');
 var anObject = require('../internals/an-object');
 var getIteratorDirect = require('../internals/get-iterator-direct');
+var notANaN = require('../internals/not-a-nan');
 var toPositiveInteger = require('../internals/to-positive-integer');
 var createAsyncIteratorProxy = require('../internals/async-iterator-create-proxy');
 
@@ -36,7 +37,7 @@ var AsyncIteratorProxy = createAsyncIteratorProxy(function (Promise, args) {
 $({ target: 'AsyncIterator', proto: true, real: true, forced: true }, {
   drop: function drop(limit) {
     return new AsyncIteratorProxy(getIteratorDirect(this), {
-      remaining: toPositiveInteger(limit)
+      remaining: toPositiveInteger(notANaN(+limit))
     });
   }
 });
diff --git a/packages/core-js/modules/esnext.async-iterator.take.js b/packages/core-js/modules/esnext.async-iterator.take.js
@@ -4,6 +4,7 @@ var $ = require('../internals/export');
 var apply = require('../internals/function-apply');
 var call = require('../internals/function-call');
 var getIteratorDirect = require('../internals/get-iterator-direct');
+var notANaN = require('../internals/not-a-nan');
 var toPositiveInteger = require('../internals/to-positive-integer');
 var createAsyncIteratorProxy = require('../internals/async-iterator-create-proxy');
 
@@ -26,7 +27,7 @@ var AsyncIteratorProxy = createAsyncIteratorProxy(function (Promise, args) {
 $({ target: 'AsyncIterator', proto: true, real: true, forced: true }, {
   take: function take(limit) {
     return new AsyncIteratorProxy(getIteratorDirect(this), {
-      remaining: toPositiveInteger(limit)
+      remaining: toPositiveInteger(notANaN(+limit))
     });
   }
 });
diff --git a/packages/core-js/modules/esnext.iterator.drop.js b/packages/core-js/modules/esnext.iterator.drop.js
@@ -5,6 +5,7 @@ var apply = require('../internals/function-apply');
 var call = require('../internals/function-call');
 var anObject = require('../internals/an-object');
 var getIteratorDirect = require('../internals/get-iterator-direct');
+var notANaN = require('../internals/not-a-nan');
 var toPositiveInteger = require('../internals/to-positive-integer');
 var createIteratorProxy = require('../internals/iterator-create-proxy');
 
@@ -26,7 +27,7 @@ var IteratorProxy = createIteratorProxy(function (args) {
 $({ target: 'Iterator', proto: true, real: true, forced: true }, {
   drop: function drop(limit) {
     return new IteratorProxy(getIteratorDirect(this), {
-      remaining: toPositiveInteger(limit)
+      remaining: toPositiveInteger(notANaN(+limit))
     });
   }
 });
diff --git a/packages/core-js/modules/esnext.iterator.take.js b/packages/core-js/modules/esnext.iterator.take.js
@@ -4,6 +4,7 @@ var $ = require('../internals/export');
 var apply = require('../internals/function-apply');
 var anObject = require('../internals/an-object');
 var getIteratorDirect = require('../internals/get-iterator-direct');
+var notANaN = require('../internals/not-a-nan');
 var toPositiveInteger = require('../internals/to-positive-integer');
 var createIteratorProxy = require('../internals/iterator-create-proxy');
 var iteratorClose = require('../internals/iterator-close');
@@ -22,7 +23,7 @@ var IteratorProxy = createIteratorProxy(function (args) {
 $({ target: 'Iterator', proto: true, real: true, forced: true }, {
   take: function take(limit) {
     return new IteratorProxy(getIteratorDirect(this), {
-      remaining: toPositiveInteger(limit)
+      remaining: toPositiveInteger(notANaN(+limit))
     });
   }
 });
diff --git a/tests/pure/esnext.async-iterator.drop.js b/tests/pure/esnext.async-iterator.drop.js
@@ -3,7 +3,7 @@ import { createIterator } from '../helpers/helpers';
 import AsyncIterator from 'core-js-pure/full/async-iterator';
 
 QUnit.test('AsyncIterator#drop', assert => {
-  assert.expect(12);
+  assert.expect(13);
   const async = assert.async();
   const { drop } = AsyncIterator.prototype;
 
@@ -29,4 +29,5 @@ QUnit.test('AsyncIterator#drop', assert => {
   assert.throws(() => drop.call({}, 1), TypeError);
   assert.throws(() => drop.call([], 1), TypeError);
   assert.throws(() => drop.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => drop.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/pure/esnext.async-iterator.take.js b/tests/pure/esnext.async-iterator.take.js
@@ -3,7 +3,7 @@ import { createIterator } from '../helpers/helpers';
 import AsyncIterator from 'core-js-pure/full/async-iterator';
 
 QUnit.test('AsyncIterator#take', assert => {
-  assert.expect(12);
+  assert.expect(13);
   const async = assert.async();
   const { take } = AsyncIterator.prototype;
 
@@ -29,4 +29,5 @@ QUnit.test('AsyncIterator#take', assert => {
   assert.throws(() => take.call({}, 1), TypeError);
   assert.throws(() => take.call([], 1), TypeError);
   assert.throws(() => take.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => take.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/pure/esnext.iterator.drop.js b/tests/pure/esnext.iterator.drop.js
@@ -19,4 +19,5 @@ QUnit.test('Iterator#drop', assert => {
   assert.throws(() => drop.call({}, 1), TypeError);
   assert.throws(() => drop.call([], 1), TypeError);
   assert.throws(() => drop.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => drop.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/pure/esnext.iterator.take.js b/tests/pure/esnext.iterator.take.js
@@ -19,4 +19,5 @@ QUnit.test('Iterator#take', assert => {
   assert.throws(() => take.call({}, 1), TypeError);
   assert.throws(() => take.call([], 1), TypeError);
   assert.throws(() => take.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => take.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/tests/esnext.async-iterator.drop.js b/tests/tests/esnext.async-iterator.drop.js
@@ -1,7 +1,7 @@
 import { createIterator } from '../helpers/helpers';
 
 QUnit.test('AsyncIterator#drop', assert => {
-  assert.expect(14);
+  assert.expect(15);
   const async = assert.async();
   const { drop } = AsyncIterator.prototype;
 
@@ -29,4 +29,5 @@ QUnit.test('AsyncIterator#drop', assert => {
   assert.throws(() => drop.call({}, 1), TypeError);
   assert.throws(() => drop.call([], 1), TypeError);
   assert.throws(() => drop.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => drop.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/tests/esnext.async-iterator.take.js b/tests/tests/esnext.async-iterator.take.js
@@ -1,7 +1,7 @@
 import { createIterator } from '../helpers/helpers';
 
 QUnit.test('AsyncIterator#take', assert => {
-  assert.expect(14);
+  assert.expect(15);
   const async = assert.async();
   const { take } = AsyncIterator.prototype;
 
@@ -29,4 +29,5 @@ QUnit.test('AsyncIterator#take', assert => {
   assert.throws(() => take.call({}, 1), TypeError);
   assert.throws(() => take.call([], 1), TypeError);
   assert.throws(() => take.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => take.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/tests/esnext.iterator.drop.js b/tests/tests/esnext.iterator.drop.js
@@ -19,4 +19,5 @@ QUnit.test('Iterator#drop', assert => {
   assert.throws(() => drop.call({}, 1), TypeError);
   assert.throws(() => drop.call([], 1), TypeError);
   assert.throws(() => drop.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => drop.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });
diff --git a/tests/tests/esnext.iterator.take.js b/tests/tests/esnext.iterator.take.js
@@ -19,4 +19,5 @@ QUnit.test('Iterator#take', assert => {
   assert.throws(() => take.call({}, 1), TypeError);
   assert.throws(() => take.call([], 1), TypeError);
   assert.throws(() => take.call(createIterator([1, 2, 3]), -1), RangeError, 'negative');
+  assert.throws(() => take.call(createIterator([1, 2, 3]), NaN), RangeError, 'NaN');
 });