IBM zSystems DFLTCC: Inline DLFTCC states into zlib states #1718
+131
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phprus
reviewed
May 2, 2024
phprus
reviewed
May 2, 2024
phprus
reviewed
May 2, 2024
Currently DFLTCC states are allocated using hook macros, complicating memory management. Inline them into zlib states and remove the hooks.
iii-i
force-pushed
the
dfltcc-inline-states
branch
from
1d657c0
to
27fcbcc
Compare
|
I didn't know about the empty struct restriction, thanks! I guess even if it were allowed, the compiler would still have to implicitly make it at least 1 byte in size in order to give it a distinct address. So I've added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DFLTCC states are allocated using hook macros, complicating memory management. Inline them into zlib states and remove the hooks.