Add parametrized testing #1448
Open
Add parametrized testing #1448
+2,371
−1,219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for output and window. In this instance if too many bytes are written it will not correctly write matches with distances close to the window size.
Add support for selcting Thread sanitizer.
* There is no need to convert between unsigned and signed vector types. All relevant intrinsics have versions for all unsigned vector types.
* Using vdupq_n_u64 duplicates the unsigned 64-bit integer to two consecutive aligned memory locations in stack so compiler can use wider load instructions. All different-sized general-purpose registers overlay on ARM/AArch64, so any vector cast is no-op in assembly.
* chunkcopy() can read or write more than the safe length if the length is not multiple of chunk size.
- Fix inflate corruption on aarch64 zlib-ng#1008 - Fix MSVC warnings zlib-ng#1002 zlib-ng#1013 - Minor chunkset improvements zlib-ng#1000 zlib-ng#994 zlib-ng#1015 - Minor cleanup zlib-ng#997 - Add CI test for pigz on aarch64 zlib-ng#1004 - Cmake improvements zlib-ng#996
Without this patch, #include <zlib.h> with Z_SOLO defined (e.g. while building perl 5.34.0) fails because of use of undefined types.
Do not use relative includes, since they are valid only within the source directory. Rely on the build system to pass the necessary include flags instead.
Transition to Ubuntu 18.04 in `GitHub` actions workflows. Fixes: ``` Ubuntu 16.04 Clang This request was automatically failed because there were no enabled runners online to process the request for more than 1 days. Ubuntu 16.04 GCC This request was automatically failed because there were no enabled runners online to process the request for more than 1 days. ``` reported for example at: https://github.com/zlib-ng/zlib-ng/actions/runs/1326434358 Official `GitHub` notice related to the removal of the 16.04 virtual environments: https://github.blog/changelog/2021-04-29-github-actions-ubuntu-16-04-lts-virtual-environment-will-be-removed-on-september-20-2021/
…viously failed test case.
…ier. * armv7 has partial support for unaligned reads, but compiler might use instructions that do not support unaligned accesses
…erage in example.
Co-authored-by: concatime <concatime@users.noreply@github.com> Co-authored-by: Mika Lindqvist <postmaster@raasu.org>
inflate() does not update strm.adler with DFLTCC. deflate() updates strm.adler even for raw streams. Fix by adding wrap checks.
… modern C implementations.
Removed tests for features not supported in 2.0.x: - cxx related settings, as stable does not use gtest/gbench. - Emscripten - Add_subdirectory - Symbol prefix - oss-fuzz, their buildfile is incompatible with this branch
…n and congestion. The free Github Actions VMs have 2 cores, the dedicated s390x VM has 4 cores.
…d the past < chunksize bytes in the window. See zlib-ng#1245. Co-authored-by: Adam Stylinski <kungfujesus06@gmail.com> Backported from commit c882034.
* Add __msan_unpoison() calls to DFLTCC inline assembly. * Make parameter block sizes symbolic constants. * Move dfltcc() definition after struct dfltcc_param_v0 definition. Backported from commit 1f5ddcc.
gzsetparams() now returns a Z_STREAM_ERROR in this case.
memLevel 9 would cause deflateBound() to assume the use of fixed blocks, even if the compression level was 0, which forces stored blocks. That could result in a bound less than the size of the compressed data. Now level 0 always uses the stored blocks bound.
A fixed block could be chosen when a stored block was smaller. Now the smaller of the two is always chosen.
Changes since 2.0.6: - Fix CVE-2022-37434 zlib-ng#1328 - Fix chunkmemset zlib-ng#1196 - Fix deflateBound too small zlib-ng#1236 - Fix Z_SOLO zlib-ng#1263 - Fix ACLE variant of crc32 zlib-ng#1274 - Fix inflateBack zlib-ng#1311 - Fix deflate_quick windowsize zlib-ng#1431 - Fix DFLTCC bugs related to adler32 zlib-ng#1349 and zlib-ng#1390 - Fix warnings zlib-ng#1194 zlib-ng#1312 zlib-ng#1362 - MacOS build fix zlib-ng#1198 - Add invalid windowBits handling zlib-ng#1293 - Support for Force TZCNT zlib-ng#1186 - Support for aligned_alloc() zlib-ng#1360 - Minideflate improvements zlib-ng#1175 zlib-ng#1238 - Dont use unaligned access for memcpy zlib-ng#1309 - Build system zlib-ng#1209 zlib-ng#1233 zlib-ng#1267 zlib-ng#1273 zlib-ng#1278 zlib-ng#1292 zlib-ng#1316 zlib-ng#1318 zlib-ng#1365 - Test improvements zlib-ng#1208 zlib-ng#1227 zlib-ng#1241 zlib-ng#1353 - Cleanup zlib-ng#1266 - Documentation zlib-ng#1205 zlib-ng#1359 - Misc improvements zlib-ng#1294 zlib-ng#1297 zlib-ng#1306 zlib-ng#1344 zlib-ng#1348 - Backported zlib fixes - Backported CI workflows from Develop branch
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## stable-pre-release #1448 +/- ##
======================================================
- Coverage 83.43% 83.40% -0.03%
======================================================
Files 76 76
Lines 8872 8872
Branches 2258 2258
======================================================
- Hits 7402 7400 -2
- Misses 1394 1399 +5
+ Partials 76 73 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
We do something similar already in CMake by testing common compression levels and known failure cases. But this looks like it may cover more cases. It would be best if this was incorporated into Google Test framework. |
|
@rhpvorderman This needs a rebase on develop, and it would also be nice if the tests were integrated into the existing test framework. Are these things you think you could do to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests is better. This simply tests if compressing a small data buffer with all possible combinations of settings is successful.
The test is a good addition, because it already finds one bug which I will make an issue for. EDIT: #1449
The C code works properly, I wonder how to best integrate this into the test suite.