Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions package dependencies #1428

Merged
merged 6 commits into from Feb 8, 2023
Merged

Update actions package dependencies #1428

merged 6 commits into from Feb 8, 2023

Conversation

Dead2
Copy link
Member

@Dead2 Dead2 commented Feb 7, 2023

This hopefully gets rid of the various deprecation warnings we have been seeing lately.
They were up to 56 warnings just for the cmake workflow.
Possibly faster to install when they are all using the same version of Node? IDK.
Some bugs have also been fixed, as well as some new features that we are not yet using.

Notable features I noticed while reading changelogs:

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 83.06% // Head: 83.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a45e61a) compared to base (a395e80).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1428   +/-   ##
========================================
  Coverage    83.06%   83.07%           
========================================
  Files          130      130           
  Lines        10784    10784           
  Branches      2787     2787           
========================================
+ Hits          8958     8959    +1     
- Misses        1131     1133    +2     
+ Partials       695      692    -3     
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 72.87% <ø> (ø)
ubuntu_clang 82.26% <ø> (+0.20%) ⬆️
ubuntu_clang_debug 81.77% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 81.92% <ø> (ø)
ubuntu_clang_inflate_strict 83.30% <ø> (+1.05%) ⬆️
ubuntu_clang_mmap 82.58% <ø> (ø)
ubuntu_clang_pigz 13.67% <ø> (ø)
ubuntu_clang_pigz_no_optim 11.29% <ø> (ø)
ubuntu_clang_pigz_no_threads 13.49% <ø> (ø)
ubuntu_clang_reduced_mem 82.75% <ø> (ø)
ubuntu_gcc 74.34% <ø> (ø)
ubuntu_gcc_aarch64 76.63% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.15% <ø> (+0.01%) ⬆️
ubuntu_gcc_aarch64_no_acle 75.63% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 75.65% <ø> (ø)
ubuntu_gcc_armhf 76.70% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.10% <ø> (ø)
ubuntu_gcc_armhf_no_acle 76.68% <ø> (ø)
ubuntu_gcc_armhf_no_neon 76.60% <ø> (ø)
ubuntu_gcc_armsf 74.06% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 73.60% <ø> (ø)
ubuntu_gcc_benchmark 72.93% <ø> (ø)
ubuntu_gcc_compat_no_opt 76.15% <ø> (ø)
ubuntu_gcc_compat_sprefix 72.78% <ø> (ø)
ubuntu_gcc_m32 72.40% <ø> (ø)
ubuntu_gcc_mingw_i686 73.20% <ø> (+0.59%) ⬆️
ubuntu_gcc_mingw_x86_64 72.65% <ø> (ø)
ubuntu_gcc_no_avx2 73.64% <ø> (ø)
ubuntu_gcc_no_ctz 74.15% <ø> (ø)
ubuntu_gcc_no_ctzll 74.18% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 73.53% <ø> (ø)
ubuntu_gcc_no_sse2 73.82% <ø> (+0.03%) ⬆️
ubuntu_gcc_no_sse4 74.17% <ø> (+0.69%) ⬆️
ubuntu_gcc_o1 74.06% <ø> (+0.69%) ⬆️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.12% <ø> (+0.02%) ⬆️
ubuntu_gcc_pigz_aarch64 39.44% <ø> (+0.02%) ⬆️
ubuntu_gcc_ppc 73.30% <ø> (ø)
ubuntu_gcc_ppc64 73.77% <ø> (ø)
ubuntu_gcc_ppc64le 73.85% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.08% <ø> (ø)
ubuntu_gcc_s390x 74.26% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 71.46% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.38% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.04% <ø> (ø)
ubuntu_gcc_sparc64 74.28% <ø> (ø)
ubuntu_gcc_sprefix 72.44% <ø> (ø)
win64_gcc 73.07% <ø> (ø)
win64_gcc_compat_no_opt 74.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gzlib.c 70.60% <0.00%> (ø)
test/minideflate.c 45.22% <0.00%> (ø)
trees.c 92.26% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nmoinvaz
Copy link
Member

nmoinvaz commented Feb 7, 2023

It is nice to know about the codecov gcov args. Right now we are calling gcovr ourselves and creating the report before sending it to codecov.

@Dead2
Copy link
Member Author

Dead2 commented Feb 7, 2023

It is nice to know about the codecov gcov args. Right now we are calling gcovr ourselves and creating the report before sending it to codecov.

Yeah, that was my first thought too. I didn't want to go down another rabbit hole right now, but if someone wants to have a look at those items now or later, feel free to.

Codecov uploader has behaved a lot better after you changed the workflow to do gcovr separately it seems, at least I don't tear my hair out over codecov not working all the time anymore. That extra step takes about 3-4s on each run (when GHA is not super-slow like yesterday after the downtime), so I figure about 2, possibly 3 sec of that could be saved if it was done in codecov directly (thus avoiding the extra pip install). Due to parallellism that would finish CI about 10-15sec faster (twice that for my PRs).
So it is not a big priority, more of a nice-have because of the simplification and the little time saved, but only IF it actually works right.

@Dead2
Copy link
Member Author

Dead2 commented Feb 7, 2023

All CI passes, this will get merged tomorrow morning unless someone objects.

@Dead2 Dead2 merged commit f96a7dc into develop Feb 8, 2023
@Dead2 Dead2 deleted the actions-deprecated branch April 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants