New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update actions package dependencies #1428
Conversation
Codecov ReportBase: 83.06% // Head: 83.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1428 +/- ##
========================================
Coverage 83.06% 83.07%
========================================
Files 130 130
Lines 10784 10784
Branches 2787 2787
========================================
+ Hits 8958 8959 +1
- Misses 1131 1133 +2
+ Partials 695 692 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It is nice to know about the codecov gcov args. Right now we are calling gcovr ourselves and creating the report before sending it to codecov. |
Clang-6.0 is still supported according to Ubuntu package list website.
135606a
to
a45e61a
Compare
Yeah, that was my first thought too. I didn't want to go down another rabbit hole right now, but if someone wants to have a look at those items now or later, feel free to. Codecov uploader has behaved a lot better after you changed the workflow to do gcovr separately it seems, at least I don't tear my hair out over codecov not working all the time anymore. That extra step takes about 3-4s on each run (when GHA is not super-slow like yesterday after the downtime), so I figure about 2, possibly 3 sec of that could be saved if it was done in codecov directly (thus avoiding the extra pip install). Due to parallellism that would finish CI about 10-15sec faster (twice that for my PRs). |
All CI passes, this will get merged tomorrow morning unless someone objects. |
This hopefully gets rid of the various deprecation warnings we have been seeing lately.
They were up to 56 warnings just for the cmake workflow.
Possibly faster to install when they are all using the same version of Node? IDK.
Some bugs have also been fixed, as well as some new features that we are not yet using.
Notable features I noticed while reading changelogs:
gcov
arguments for the Codecov uploader codecov/codecov-action#688