Skip to content

Commit

Permalink
fix: _key_value for schedulers in case of multiple optimizers fixed (
Browse files Browse the repository at this point in the history
  • Loading branch information
bagxi authored and zkid18 committed Apr 4, 2021
1 parent b1ad3e4 commit a5334fe
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added gradient clipping function to optimizer callback ([1124](https://github.com/catalyst-team/catalyst/pull/1124))
- FactorizedLinear to contrib ([1142](https://github.com/catalyst-team/catalyst/pull/1142))
- Extra init params for ``ConsoleLogger`` ([1142](https://github.com/catalyst-team/catalyst/pull/1142))
- `_key_value` for schedulers in case of multiple optimizers fixed ([#1146](https://github.com/catalyst-team/catalyst/pull/1146))

### Changed

Expand Down
4 changes: 2 additions & 2 deletions catalyst/runners/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,9 @@ def _get_scheduler_from_params(*, optimizer: RunnerOptimizer, **params) -> Runne
for key, scheduler_params in params.items():
scheduler_params = deepcopy(scheduler_params)
optimizer_key = scheduler_params.pop("_optimizer", None)
optimizer = optimizer[optimizer_key] if optimizer_key else optimizer
optim = optimizer[optimizer_key] if optimizer_key else optimizer
scheduler[key] = ConfigRunner._get_scheduler_from_params(
**scheduler_params, optimizer=optimizer
**scheduler_params, optimizer=optim
) # noqa: WPS437
else:
optimizer_key = params.pop("_optimizer", None)
Expand Down
4 changes: 2 additions & 2 deletions catalyst/runners/hydra.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,9 @@ def _get_scheduler_from_params(
for key, scheduler_params in params.items():
scheduler_params = deepcopy(scheduler_params)
optimizer_key = scheduler_params._optimizer or None
optimizer = optimizer[optimizer_key] if optimizer_key else optimizer
optim = optimizer[optimizer_key] if optimizer_key else optimizer
scheduler[key] = HydraRunner._get_scheduler_from_params( # noqa: WPS437
optimizer=optimizer, params=scheduler_params
optimizer=optim, params=scheduler_params
)
else:
optimizer_key = params._optimizer or None
Expand Down

0 comments on commit a5334fe

Please sign in to comment.