Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #369 (Loss of Diagnostic information when Report is converted to Box<dyn Diagnostic>) #370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #369 (Loss of Diagnostic information when Report is converted to Box<dyn Diagnostic>) #370

wants to merge 3 commits into from

Commits on Apr 25, 2024

  1. test: un-ignore test_boxed_sources 

    I didn't even fix this one, it was just passing!
    @TheLostLambda
    TheLostLambda committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4a4111b View commit details
    Browse the repository at this point in the history

  2. test(boxed): add failing test for bug zkat#369

    @TheLostLambda
    TheLostLambda committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b087000 View commit details
    Browse the repository at this point in the history

  3. fix(report): conversion into Box<dyn Diagnostic> 

    Diagnostic impls are no longer reset to default when converting a
`Report` into a `Box<dyn Diagnostic>`. Also prevented `Report` vtables
and handlers from being kept around on the heap after conversion.
    @TheLostLambda
    TheLostLambda committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c4f6431 View commit details
    Browse the repository at this point in the history