-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero length span #356
base: main
Are you sure you want to change the base?
Zero length span #356
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f8fbf8 - Browse repository at this point
Copy the full SHA 6f8fbf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a37328a - Browse repository at this point
Copy the full SHA a37328aView commit details -
fix(SourceCode): Fix and improve default
SourceCode
implementation- Fix a panic when a 0 length span covers the end of a document - Fix incorrect `line_count` - Add new unit tests and complete existing ones - Improve readability
Configuration menu - View commit details
-
Copy full SHA for f7fa50d - Browse repository at this point
Copy the full SHA f7fa50dView commit details -
fix(zero length, no context): Add Option to distinguish between "curr…
…ent line" and "just the span" Fixes zkat#355 Change the number of context lines from usize to Option<usize> to allow choosing between "just the span" (as implemented previously when using 0 context line) using `None`, and displaying the error line without extra context (not possible before) using `Some(0)`.
Configuration menu - View commit details
-
Copy full SHA for d63b2bb - Browse repository at this point
Copy the full SHA d63b2bbView commit details -
fix(miri): remove or mark as dead_code unused internal structs
- Mark as dead_code the structs uses in testing - Remove unused code inherited from Eyre for converting `Option` into `Result`
Configuration menu - View commit details
-
Copy full SHA for d0c1143 - Browse repository at this point
Copy the full SHA d0c1143View commit details
Commits on Mar 22, 2024
-
fix(zero length): Improve rendering for zero-length error spans
A zero-length span at a line boundary can be associated either with the previous or the next line. Current code prefer to use the next line, however there isn't always a "next line" (end of source, or "no context" configuration). There is also the extra-special case of an empty document which has no "next line" but also no "previous line". This commit adds an empty newline at the end of a document if appropriate so that there is a "next line", or use the "previous line"
Configuration menu - View commit details
-
Copy full SHA for c7cbb07 - Browse repository at this point
Copy the full SHA c7cbb07View commit details