Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature "fancy-no-syscall" for wasm targets #349

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Feb 22, 2024

I added

  • fancy-base feature to enable exports for the fancy feature
  • fancy-no-syscall feature to disable all syscalls
  • a wasm ci check to ensure future changes.

target_family = "wasm" will not work in this case because terminal_size will not compile under wasm32-unknown-unknown, the dependency has to be excluded.

@Boshen Boshen marked this pull request as ready for review February 22, 2024 07:55
@zkat zkat merged commit 328bf37 into zkat:main Feb 23, 2024
15 checks passed
@Boshen
Copy link
Contributor Author

Boshen commented Feb 23, 2024

Thank you! I'll test this in my project tomorrow, let's make a release after I've confirmed the fancy features works on all systems.

@Boshen
Copy link
Contributor Author

Boshen commented Feb 24, 2024

I have verified both features fancy-no-syscall and fancy-no-backtrace are working as intended.

@Boshen
Copy link
Contributor Author

Boshen commented Mar 7, 2024

@zkat A new release would be greatly appreciated 🤝

@zkat
Copy link
Owner

zkat commented Mar 7, 2024

@Boshen done. Should be out in 7.2.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile to wasm32-unknown-unknown / Compile without terminal_size
2 participants