fix(tests): revert test-breaking changes of e5c7ae4 #339
Conversation
The commit e5c7ae4 seemed to (potentially erronously?) remove a number of spaces following the left `|` bar of some graphical report handler tests. That change had no effect on the `syntax_highlighter_on_real_file()` test, presumably because the trailing whitespace is removed by `strip_ansi_escapes::strip_str()`, but it did break the `triple_adjacent_highlight()` and `non_adjacent_hightlight()` tests. Restoring the spaces removed in e5c7ae4 fixes the failing tests on main.
|
Well, I fixed the main issue, but this second half has been quite the dramatic journey... It's a issue introduced by a combination of a new nightly Rust version (used in that CI test to use the unstable minimal-versions flag) and an old version of It looks like |
|
Just kidding, the offending This actually seems to be the issue cautioned against in the unstable feature description for I've changed the flag in the CI and bumped a couple of versions that were out of sync between |
|
Tada! CI fixed! |
The commit e5c7ae4 seemed to (potentially erronously?) remove a number of spaces following the left
|bar of some graphical report handler tests. That change had no effect on thesyntax_highlighter_on_real_file()test, presumably because the trailing whitespace is removed bystrip_ansi_escapes::strip_str(), but it did break thetriple_adjacent_highlight()andnon_adjacent_hightlight()tests. Restoring the spaces removed in e5c7ae4 fixes the failing tests on main.