rendering bug on small spans in large spans #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out there were two really. One related to how many characters were added for the arrowheads in the gutter, and one where the gutter was extended to a number of characters, including ansi escape codes. However, because ansi escape codes are rather big, there would never be any extension since the system thought the string was already long enough, even though you don't actually see the width of those codes.
jdonszelmann
force-pushed
the
rendering-bug
branch
from
5e9d8c2
to
5eea253
Compare
This was referenced Nov 9, 2023
|
Can you fix the conflicts here? |
|
Yes! One sec |
jdonszelmann
force-pushed
the
rendering-bug
branch
from
3aef998
to
2c704bb
Compare
|
@zkat there ya go! Thanks for having started such an awesome project 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #317. This contributes a test for #317 and then fixes the bug :)
Closes #317
The bad screenshot from #317
now becomes this with the proposed changes:
Note that there were actually two subtle bugs. One was the double arrow in the gutter problem, which also occurred when rendering without ansi escape codes. However, this line
miette/src/handlers/graphical.rs
Line 611 in a8b4ae0
Also did not work when the gutter contains ansi escape codes. It extends to the
widthvariable, but when the string contains ansi codes it does not actually add any spaces since it thinks the escape codes have width as well. They of course do not, so the output doesn't look right. Unfortunately this is quite hard to make tests for.