Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group related diagnostics visually #171

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Group related diagnostics visually #171

wants to merge 7 commits into from

Commits on May 6, 2022

  1. Add more tests for diagnostic_source

    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    8ba24da View commit details
    Browse the repository at this point in the history

  2. Use Borrow::borrow instead of AsRef 

    AsRef is not reflexive, meaning that it is not implemented as &T for all
T. Borrow is though, so we use that to make sure that we always get a
reference that is correct, even in the presence of smart pointers.
    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3914726 View commit details
    Browse the repository at this point in the history

  3. Add test verifying diagnostic

    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    1643cab View commit details
    Browse the repository at this point in the history

  4. Render inner diagnostic with a renderer 

    Previously diagnostics just had their StdError Display implementation
called. This now uses a GraphicalReport if wished.
    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    db8949f View commit details
    Browse the repository at this point in the history

  5. Only print a newline sep. when there is a header

    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    54ede01 View commit details
    Browse the repository at this point in the history

  6. Update tests for different newline printing

    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2b9b6af View commit details
    Browse the repository at this point in the history

  7. Group related diagnostics with a graphical line

    @TheNeikos
    TheNeikos committed May 6, 2022
    Configuration menu
    Copy the full SHA
    c7ebcaf View commit details
    Browse the repository at this point in the history