fix: missing RawTransfer event emission
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RawTransfer` event that's meant to enable offchain raw balance tracking was incorrectly not emitted in certain cases, defeating its own purpose. This commit fixes it. Note that since it's impossible to apply the fix retrospectively, users before this fix is deployed would have broken history. A separate mechanism is needed to somehow "snapshot" raw balances of old users to allow offchain indexing applications to reconcile accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RawTransferevent that's meant to enable offchain raw balance tracking was incorrectly not emitted in certain cases, defeating its own purpose. This commit fixes it.Note that since it's impossible to apply the fix retrospectively, users before this fix is deployed would have broken history. A separate mechanism is needed to somehow "snapshot" raw balances of old users to allow offchain indexing applications to reconcile accordingly.