Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: homepage, concepts cleanup #2643

Merged
merged 37 commits into from Jan 11, 2022
Merged

docs: homepage, concepts cleanup #2643

merged 37 commits into from Jan 11, 2022

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Nov 8, 2021

Bildschirmfoto 2021-12-21 um 15 01 59

Bildschirmfoto 2021-12-21 um 15 02 28

@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 8, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70b8ebc
Status: ✅  Deploy successful!
Preview URL: https://8b5d4956.zitadel.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2643 (70b8ebc) into main (e624047) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2643   +/-   ##
=======================================
  Coverage   51.37%   51.37%           
=======================================
  Files         705      705           
  Lines       40018    40020    +2     
=======================================
+ Hits        20558    20560    +2     
  Misses      18061    18061           
  Partials     1399     1399           
Impacted Files Coverage Δ
...epository/eventsourcing/eventstore/auth_request.go 28.41% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e624047...70b8ebc. Read the comment docs.

@peintnermax peintnermax changed the title docs: architecture scenarios (b2c, b2b, ...more later) docs: architecture scenarios (b2c, b2b), homepage, concepts cleanup Nov 11, 2021
@peintnermax
Copy link
Member Author

@fforootd @livio-a could you take a look at the b2b, b2c texts if this makes sense. If so, could you extend Access Control and maybe what we do for attack prevention (in B2C) 😀

@peintnermax peintnermax added the help wanted Extra attention is needed label Nov 11, 2021
@peintnermax peintnermax removed the help wanted Extra attention is needed label Dec 21, 2021
@peintnermax peintnermax marked this pull request as ready for review December 21, 2021 14:00
@peintnermax peintnermax changed the title docs: architecture scenarios (b2c, b2b), homepage, concepts cleanup docs: homepage, concepts cleanup Dec 21, 2021
docs/src/pages/index.js Outdated Show resolved Hide resolved
@fforootd
Copy link
Member

When @fgerschwiler has no objections is would recommend merging this 😁

Co-authored-by: Florian Forster <florian@caos.ch>
docs/sidebars.js Outdated Show resolved Hide resolved
@fforootd
Copy link
Member

With Node.js version >v17 we will starting see an error

  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

This relates to facebook/docusaurus#5814

A simple upgrade should do the trick without using the legacy flags

@fforootd
Copy link
Member

@peintnermax do you have any ideas around this error?

image

image

@peintnermax
Copy link
Member Author

peintnermax commented Jan 3, 2022

the new docusaurus version had a problem with our login-users guide, so i cleaned it up. The commented architecture scenarios are not yet reviewed so I would have merged the new homepage and concepts in the meantime :)

@fforootd
Copy link
Member

fforootd commented Jan 4, 2022

The commented architecture scenarios are not yet reviewed so I would have merged the new homepage and concepts in the meantime :)

@mffap @fgerschwiler any comments from your sides for the guides?

@mffap
Copy link
Member

mffap commented Jan 5, 2022

The commented architecture scenarios are not yet reviewed so I would have merged the new homepage and concepts in the meantime :)

@mffap @fgerschwiler any comments from your sides for the guides?

CF built failed, so I can't preview. Did something material change?

peintnermax and others added 6 commits January 5, 2022 16:30
Co-authored-by: mffap <mpa@caos.ch>
Co-authored-by: mffap <mpa@caos.ch>
Co-authored-by: mffap <mpa@caos.ch>
Co-authored-by: mffap <mpa@caos.ch>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
@peintnermax
Copy link
Member Author

peintnermax and others added 2 commits January 7, 2022 08:55
Co-authored-by: Livio Amstutz <livio.a@gmail.com>
Co-authored-by: Livio Amstutz <livio.a@gmail.com>
@fforootd fforootd added the docs Improvements or additions to documentation label Jan 10, 2022
@fforootd
Copy link
Member

@peintnermax @livio-a

You broke some links can you have a look into this? 🙇
The test can be run with yarn build

[ERROR] Unable to build website for locale en.
[ERROR] Error: Docusaurus found broken links!

Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

It looks like some of the broken links we found appear in many pages of your site.
Maybe those broken links appear on all pages through your site layout?
We recommend that you check your theme configuration for such links (particularly, theme navbar and footer).
Frequent broken links are linking to:
- ../../apis/openidoauth/endpoints#authorization_endpoint
- ../../apis/openidoauth/endpoints#error-response


Exhaustive list of all broken links found:

- On source page path = /docs/guides/authentication/authmethods/basic:
   -> linking to ../../apis/openidoauth/endpoints#authorization_endpoint (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/endpoints#error-response (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/authn-methods#client-secret-basic (resolved as: /docs/guides/apis/openidoauth/authn-methods)

- On source page path = /docs/guides/authentication/authmethods/implicit:
   -> linking to ../../apis/openidoauth/endpoints#authorization_endpoint (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/endpoints#error-response (resolved as: /docs/guides/apis/openidoauth/endpoints)

- On source page path = /docs/guides/authentication/authmethods/jwtpk:
   -> linking to ../../apis/openidoauth/endpoints#authorization_endpoint (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/endpoints#error-response (resolved as: /docs/guides/apis/openidoauth/endpoints)

- On source page path = /docs/guides/authentication/authmethods/pkce:
   -> linking to ../../apis/openidoauth/endpoints#authorization_endpoint (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/endpoints#error-response (resolved as: /docs/guides/apis/openidoauth/endpoints)

- On source page path = /docs/guides/authentication/authmethods/pkcenative:
   -> linking to ../../apis/openidoauth/endpoints#authorization_endpoint (resolved as: /docs/guides/apis/openidoauth/endpoints)
   -> linking to ../../apis/openidoauth/endpoints#error-response (resolved as: /docs/guides/apis/openidoauth/endpoints)

    at reportMessage (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/utils/lib/index.js:306:19)
    at handleBrokenLinks (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/core/lib/server/brokenLinks.js:138:35)
    at async buildLocale (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/core/lib/commands/build.js:155:5)
    at async tryToBuildLocale (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/core/lib/commands/build.js:33:20)
    at async mapAsyncSequencial (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/utils/lib/index.js:262:24)
    at async build (/home/ffo/workdir/zitadel/docs/node_modules/@docusaurus/core/lib/commands/build.js:68:25)
error Command failed with exit code 1.

@fforootd
Copy link
Member

@peintnermax this looks good to me

@fforootd fforootd dismissed mffap’s stale review January 11, 2022 19:47

Feedback is incorporated

@fforootd fforootd merged commit 68827df into main Jan 11, 2022
@fforootd fforootd deleted the b2bguide branch January 11, 2022 19:48
@github-actions
Copy link

🎉 This PR is included in version 1.69.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants