New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: zitadel server #63
base: main
Are you sure you want to change the base?
Conversation
@yordis is attempting to deploy a commit to the zitadel Team on Vercel. A member of the Team first needs to authorize it. |
967e834
to
7b7c28a
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @yordis thx for this amazing PR. When compiling we have a couple of issues. |
a1b349e
to
7219bc3
Compare
@peintnermax sorry for the whole mess, I am trying to upgrade deps and get the entire setup to compile properly. I got the basic refactoring to the server, but the DevOps and whatnot are giving me trouble, and I got too deep into upgrading things by now ... Hopefully it is worth it |
@peintnermax is there anyway to ping to a tag version the |
7219bc3
to
fbf7f55
Compare
43b69a7
to
c9967e0
Compare
Any help is greatly appreciated.. Thx for your effort 😎👍 |
e7881f8
to
ba081ed
Compare
87b098d
to
8eb07a0
Compare
8eb07a0
to
bfd7213
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
bfd7213
to
f36df05
Compare
Context
Primary
Refactor the
@zitadel/server
to remove singletons and extra indirection around initializing the clients. Depending on the users ' needs, application-level code decides whether to use single-client or multi-client code.Under
apps/login,
I simplify the clients' usage. Since the functions are defined in the same file (or could be imported directly), the code does not need to be passed around;UNLESS
multi-client is required.Also, some abstractions add extra indirections around the SDK API with little value. Since the SDK API already has structured messages, I removed most of them, except the ones that shared some "Message Structure Logic."
Since there are collisions between protobuf services, we need to expose the client around the protobuf service, for example,
SearchQuery
fromsession
anduser
; we can not hide the layout of the services!Extras
#/
to@/
, just for familiarityDefinition of Ready