Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add proposal issue template #55

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

hifabienne
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #55 (8838105) into main (cc9378c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   47.26%   47.26%           
=======================================
  Files          21       21           
  Lines        1976     1976           
=======================================
  Hits          934      934           
  Misses        984      984           
  Partials       58       58           

@hifabienne hifabienne marked this pull request as ready for review June 1, 2023 05:10
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late.
We need @stebenz's help, I guess

Comment on lines +42 to +46
- type: textarea
id: screenshots
attributes:
label: Screenshots
description: If applicable, add screenshots to help explain your problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better a field for logs @stebenz?
Maybe also a field for config?

Comment on lines +40 to +49
- type: dropdown
id: environment
attributes:
label: Environment
description: How do you use ZITADEL?
options:
- ZITADEL Cloud
- Self-hosted
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library is not only intended to be used with ZITADEL, right @stebenz? If not particularly, I'd replace this field. Maybe, the apps that are connected are interesting?
Same in the improvement template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right didn't think about this.

@hifabienne hifabienne requested review from livio-a and removed request for livio-a August 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants