Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle case where verifier Nonce func is nil #594

Merged
merged 2 commits into from May 2, 2024

Conversation

ymarcus93
Copy link
Contributor

The Nonce func in IDTokenVerifier can technically be set to nil. We don't want to panic by calling a nil func. So I've updated the VerifyIDToken func to skip the nonce claim check if the func is nil.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link
Member

@livio-a livio-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymarcus93 thank you for the fix.

If you like to get a gift from us, please write an email to hi@zitadel.com

@livio-a livio-a merged commit 24d43f5 into zitadel:main May 2, 2024
6 of 7 checks passed
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 3.23.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants