Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetchRemoteKeys context to include in request #593

Merged
merged 2 commits into from Apr 22, 2024

Conversation

otakakot
Copy link
Contributor

Fixed to include the context in which the span was created in the request.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (0992c5f) to head (ab95dfd).
Report is 52 commits behind head on main.

❗ Current head ab95dfd differs from pull request most recent head 80241fc. Consider uploading reports for the commit 80241fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   60.06%   62.17%   +2.11%     
==========================================
  Files          80       81       +1     
  Lines        6998     6192     -806     
==========================================
- Hits         4203     3850     -353     
+ Misses       2498     2037     -461     
- Partials      297      305       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hifabienne hifabienne requested a review from livio-a April 22, 2024 09:35
@livio-a livio-a enabled auto-merge (squash) April 22, 2024 11:39
@livio-a
Copy link
Member

livio-a commented Apr 22, 2024

@otakakot thanks for the fix

@livio-a livio-a merged commit 3512c72 into zitadel:main Apr 22, 2024
4 checks passed
Copy link

🎉 This PR is included in version 3.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants