Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail safe, if optional endpoints are not given #582

Merged
merged 2 commits into from Apr 9, 2024

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Apr 5, 2024

If discovery document doesn't contains some optional endpoints, calling some endpoints functions may fail hard

Example with end session

Before:

Post "": unsupported protocol scheme ""

After:

end session endpoint not set

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.03%. Comparing base (0992c5f) to head (1c66947).
Report is 40 commits behind head on main.

Files Patch % Lines
pkg/client/client.go 16.66% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   60.06%   62.03%   +1.97%     
==========================================
  Files          80       80              
  Lines        6998     6169     -829     
==========================================
- Hits         4203     3827     -376     
+ Misses       2498     2037     -461     
- Partials      297      305       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer enabled auto-merge (squash) April 9, 2024 13:01
@muhlemmer muhlemmer merged commit 06f37f8 into zitadel:main Apr 9, 2024
4 checks passed
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jkroepke jkroepke deleted the endpoint-not-set branch April 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants