feat: Added the ability to verify ID tokens using the value of id_token_signing_alg_values_supported retrieved from DiscoveryEndpoint

[otakakot]

Definition of Ready

fixes #574

Fixed discoveryConfiguration.IDTokenSigningAlgValuesSupported to be set to WithSupportedSigningAlgorithms().

I thought about adding and setting discoveryConfiguration to the relyingParty struct field and doing for _, optFunc := range options{} after getting discoveryConfiguration, WithCustomDiscoveryUrl() had to be processed before client.Discover().

• I am happy with the code
• Short description of the feature/issue is added in the pr description
• PR is linked to the corresponding user story
• Acceptance criteria are met
• All open todos and follow ups are defined in a new ticket and justified
• Deviations from the acceptance criteria and design are agreed with the PO and documented.
• No debug or dead code
• My code has no repetitions
• Critical parts are tested automatically
• Where possible E2E tests are implemented
• Documentation/examples are up-to-date
• All non-functional requirements are met
• Functionality of the acceptance criteria is checked manually on the dev system.

[otakakot]

I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?

[muhlemmer]

I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?

You could add an integration test that starts the example OP and then initialize the RP with your the new option.

oidc/pkg/client/integration_test.go

Lines 63 to 71 in 8a21d38

	func testRelyingPartySession(t *testing.T, wrapServer bool) {
	t.Log("------- start example OP ------")
	targetURL := "http://local-site"
	exampleStorage := storage.NewStorage(storage.NewUserStore(targetURL))
	var dh deferredHandler
	opServer := httptest.NewServer(&dh)
	defer opServer.Close()
	t.Logf("auth server at %s", opServer.URL)
	dh.Handler = exampleop.SetupServer(opServer.URL, exampleStorage, Logger, wrapServer)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (0992c5f) to head (9e700d2).
Report is 49 commits behind head on main.

❗ Current head 9e700d2 differs from pull request most recent head 0553090. Consider uploading reports for the commit 0553090 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   60.06%   62.17%   +2.11%     
==========================================
  Files          80       81       +1     
  Lines        6998     6192     -806     
==========================================
- Hits         4203     3850     -353     
+ Misses       2498     2037     -461     
- Partials      297      305       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[muhlemmer]

@otakakot I understood you still want to add tests, is that correct? I am waiting with the review until that's done.

[otakakot]

@muhlemmer Excuse me, may I have a review at this stage?

[muhlemmer]

The implementation looks good to me 👍

[otakakot]

I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?

You could add an integration test that starts the example OP and then initialize the RP with your the new option.

oidc/pkg/client/integration_test.go

Lines 63 to 71 in 8a21d38

	func testRelyingPartySession(t *testing.T, wrapServer bool) {
	t.Log("------- start example OP ------")
	targetURL := "http://local-site"
	exampleStorage := storage.NewStorage(storage.NewUserStore(targetURL))
	var dh deferredHandler
	opServer := httptest.NewServer(&dh)
	defer opServer.Close()
	t.Logf("auth server at %s", opServer.URL)
	dh.Handler = exampleop.SetupServer(opServer.URL, exampleStorage, Logger, wrapServer)

7572353 Tests have been added.

[github-actions]

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀