Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support verification_url workaround for DeviceAuthorizationResponse unmarshal #577

Merged
merged 2 commits into from Apr 8, 2024

Conversation

celian-garcia
Copy link
Contributor

fixes #565

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.15%. Comparing base (0992c5f) to head (1b67996).
Report is 40 commits behind head on main.

Files Patch % Lines
pkg/oidc/device_authorization.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   60.06%   62.15%   +2.09%     
==========================================
  Files          80       81       +1     
  Lines        6998     6172     -826     
==========================================
- Hits         4203     3836     -367     
+ Misses       2498     2031     -467     
- Partials      297      305       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@celian-garcia
Copy link
Contributor Author

Hi @muhlemmer, any news? this PR is quite a no brainer.

@muhlemmer muhlemmer enabled auto-merge (squash) April 8, 2024 13:42
@muhlemmer
Copy link
Collaborator

Sorry, I was quite busy the last days. Everything looks ok 👍

@muhlemmer muhlemmer merged commit e75a061 into zitadel:main Apr 8, 2024
4 checks passed
Copy link

github-actions bot commented Apr 8, 2024

🎉 This PR is included in version 3.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support verification_url mispelling in the device auth response
2 participants