Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): improve error messages #38

Merged
merged 10 commits into from Jul 29, 2020
Merged

fix(errors): improve error messages #38

merged 10 commits into from Jul 29, 2020

Commits on Jul 28, 2020

  1. Update authrequest.go 

    Rewrote error messages with a consistent structure to explain said errors, as well as a transition to the administrator's contact information. The administrator's information will needed to be plugged in by a more knowledgeable contributor.

Note that because I am not familiar with Go, some of the error messages may have an incorrect explanation for the error. I encourage a double check on the terminology and logic explained in my messages. If there are any errors, please correct the terminology and logic while retaining the sentence structure.
    @JCustin
    JCustin committed Jul 28, 2020
    Copy the full SHA
    e54ab63 View commit details
    Browse the repository at this point in the history

  2. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    9c8698d View commit details
    Browse the repository at this point in the history

  3. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    858a527 View commit details
    Browse the repository at this point in the history

  4. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    d653ed7 View commit details
    Browse the repository at this point in the history

  5. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    cd1c364 View commit details
    Browse the repository at this point in the history

  6. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    f6f8cba View commit details
    Browse the repository at this point in the history

  7. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    f552b1c View commit details
    Browse the repository at this point in the history

  8. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    b2d043a View commit details
    Browse the repository at this point in the history

  9. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    c689756 View commit details
    Browse the repository at this point in the history

  10. Update pkg/op/authrequest.go 

    Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
    @JCustin @hifabienne
    JCustin and hifabienne committed Jul 28, 2020
    Copy the full SHA
    e6356f1 View commit details
    Browse the repository at this point in the history