Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to Symfony 5 and Twig 3 #4018

Merged
merged 35 commits into from Dec 30, 2019
Merged

Updated to Symfony 5 and Twig 3 #4018

merged 35 commits into from Dec 30, 2019

Conversation

Guite
Copy link
Member

@Guite Guite commented Dec 26, 2019 •
edited

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets #3377, #3997, #3998, #4014
Refs tickets #4012
License MIT
Changelog updated yes

Description

This adds updates to Twig 3 and Symfony 5.
Also it updates many other bundles and extensions.

@Guite Guite added this to the 3.0.0 milestone Dec 26, 2019
@Guite Guite changed the title [WIP] first steps to Symfony 5 and Twig 3 [DO NOT MERGE YET] [WIP] Updates for Symfony 5 and Twig 3 [DO NOT MERGE YET] Dec 26, 2019
@Guite
use release version
54b5583
@Guite
set allowEmptyString attribute for length validator
31d552f
@Guite
raised min php version to 7.2.5
4b8b361
@Guite
Merge branch 'master' into updates
aed60bb
@Guite
removed support for legacy events
788c38e
@Guite
Merge branch 'master' into updates
5a91e9d
@Guite
removed custom IntlExtension
bf52a56
@Guite
updated Routes
a3a851a
@Guite
some first patches
4d2dffa
@Guite
workaround
f2473d5
@Guite
cs
fa982e0
@Guite
readded html extra extension
8198adc
@Guite
further updates
f14698f
@Guite
Merge branch 'master' into updates
0e9037f
@Guite
Merge branch 'master' into updates
dce438b
@Guite
updated Twig filters
7e0b78d
@Guite
Merge branch 'master' into updates
6ef54d3
@Guite
vendor update
d0ae9c8
@Guite
added twig extra bundle to kernel
2877f4f
@Guite
Node methods expect a string now
810b734
@Guite
Merge branch 'master' into updates
25d9bc4
@Guite
Merge branch 'master' into updates
1472c7c
@Guite
Merge branch 'master' into updates
f034503
@Guite
minor optimisation
274d128
@Guite
Merge branch 'master' into updates
a5f6a5d
@Guite
Merge branch 'master' into updates
ea6143e
@Guite
Merge branch 'master' into updates
4c4e45c
@Guite Guite mentioned this pull request Dec 30, 2019
Closed
@Guite Guite changed the title [WIP] Updates for Symfony 5 and Twig 3 [DO NOT MERGE YET] Updated to Symfony 5 and Twig 3 Dec 30, 2019
@Guite Guite requested a review from craigh December 30, 2019 11:58
craigh
craigh approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@craigh craigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems really good. It is surprising to me how few actual changes were needed (aside from needed Vendor updates). Did you try the http installer?

build/BuildPackageCommand.php Outdated Show resolved Hide resolved
src/lib/Zikula/Bundle/CoreBundle/CacheClearer.php Show resolved Hide resolved
src/system/ThemeModule/composer.json Show resolved Hide resolved
@Guite
Copy link
Member Author

Guite commented Dec 30, 2019

Currently looking into the getParameter() issue. Will merge afterwards.

@Guite Guite merged commit 91a93df into master Dec 30, 2019
@Guite Guite deleted the updates branch December 30, 2019 13:23
This was referenced Dec 30, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigh craigh craigh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Guite @craigh