Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quirk for Ikea TRETAKT Smart Plug #3145

Closed

Conversation

jasimancas
Copy link
Contributor

@jasimancas jasimancas commented May 10, 2024

Proposed change

The new Ikea plug exposes entities that are not correct and do not work, this quirk solves them by exposing only the parameters of a plug.

image

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (bfbfb48) to head (a2d2c26).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3145      +/-   ##
==========================================
+ Coverage   88.14%   88.15%   +0.01%     
==========================================
  Files         299      300       +1     
  Lines        9389     9398       +9     
==========================================
+ Hits         8276     8285       +9     
  Misses       1113     1113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattWestb
Copy link
Contributor

IKEA is using light level with On/Off then doing direct pairing of there controllers and they looks using the same cluster setting doing coordinator paring.
Very likely its the same with ÅSKVÄDER Zigbee module but i have not looking on it then its no problem for me.

Good work done !!!

@MattWestb
Copy link
Contributor

@TheJulianJES Shall we not having the manufacture cluster in the replacement so not loosing future possible functions ?

@jasimancas
Copy link
Contributor Author

BTW, new cluster in this device: 0xFC85

@MattWestb
Copy link
Contributor

Yes i was seen it and its not used in any github repros for Zigbee.
IKEA is some time making manufacture cluster then its not in the current Zigbee ZCL but is coming in the next like Symfonisk gen 2 have one matter switch cluster (on 2 endpoints) that is not in Zigbee ZCL but they only need changing the number and they can piping it thru the matter bridge and all is 95% matter compatible or they is fixing it the the controller firmware with OTA.

IKEA_SHORTCUT_CLUSTER_V1_ID = 0xFC7F # decimal = 64639 Shortcut V1 commands
IKEA_MATTER_SWITCH_CLUSTER_ID = 0xFC80 # decimal = 64640 Shortcut V2 commands

@jasimancas
Copy link
Contributor Author

@MattWestb Is something else expected from me or am I just waiting for the merge?

@MattWestb
Copy link
Contributor

Its depend of the maintainers if they like have some changes made or if no needed the shall merging it sooner or later.

@TheJulianJES
Copy link
Collaborator

Thanks for the PR!

I think we can simplify this with quirks v2 now, so we don't need to match the whole signature.
If you can, please test the quirk file from this PR:

You can just install it as a custom quirk. See if the same behavior (of removing the LevelControl cluster) is achieved (for both plugs).

@MattWestb You're also welcome to test that quirk of course!

@jasimancas
Copy link
Contributor Author

Continue in: #3174

@jasimancas jasimancas closed this May 29, 2024
@jasimancas jasimancas deleted the device/ikea_tretakt_smart_plug_quirk branch May 29, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants