Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya TS0601 temp sensor variants, enable data query spell #3036

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jacekk015
Copy link
Contributor

@jacekk015 jacekk015 commented Mar 13, 2024

Added:

            ("_TZE204_9yapgbuv", "TS0601"),
            ("_TZE204_upagmta9", "TS0601"),
            ("_TZE200_upagmta9", "TS0601"),
            ("_TZE200_cirvgep4", "TS0601"),

According to Z2M those are equivalents.
DP are compatible
https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/tuya.ts#L724

Sensors quirk are requested:
#2694
#2854

[edit]
Added EnchantedDevice to Device
Added TuyaEnchantableCluster to Temp cluster
Added tuya_spell_data_query = True to Device
as needed by
#2694 (comment)

According to Z2M those are equivalents.
DP are compatible
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (86fafd6) to head (6a1638b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3036   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         301      301           
  Lines        9219     9220    +1     
=======================================
+ Hits         8100     8101    +1     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added EnchantedDevice to Device
Added TuyaEnchantableCluster to Temp cluster
Added tuya_spell_data_query = True to Device
SKIP_CONFIGURATION removed
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Mar 13, 2024
@javicalle
Copy link
Collaborator

Maybe we can sort the MODELS_INFO array:

        MODELS_INFO: [
            ("_TZE200_9yapgbuv", "TS0601"),
            ("_TZE204_9yapgbuv", "TS0601"),
            ("_TZE200_cirvgep4", "TS0601"),
            ("_TZE200_upagmta9", "TS0601"),
            ("_TZE204_upagmta9", "TS0601"),
            ("_TZE200_utkemkbs", "TS0601"),
            ("_TZE204_utkemkbs", "TS0601"),
            ("_TZE200_yjjdcqsq", "TS0601"),
            ("_TZE204_yjjdcqsq", "TS0601"),
        ],

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacekk015 jacekk015 marked this pull request as draft March 14, 2024 09:24
@jacekk015
Copy link
Contributor Author

@javicalle Some user reported that magic spells didn't made the device fully functional.
More work/debug needed

@TheJulianJES TheJulianJES changed the title Update ts0601_sensor.py Add Tuya TS0601 temp sensor variants, enable data query spell Mar 18, 2024
@roblamoreaux
Copy link

I tried this on my local HA system, and the entity to change the temperature display units doesn't show up. My understanding is the unit does not send updates until the temperature units it set, instead it just runs the battery down trying to connect to Tuya. My unit therefore did not show any values and drained the battery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants