-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya TS0601 temp sensor variants, enable data query spell #3036
base: dev
Are you sure you want to change the base?
Conversation
According to Z2M those are equivalents. DP are compatible
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3036 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 301 301
Lines 9219 9220 +1
=======================================
+ Hits 8100 8101 +1
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
Added EnchantedDevice to Device Added TuyaEnchantableCluster to Temp cluster Added tuya_spell_data_query = True to Device
SKIP_CONFIGURATION removed
Code cleanup
Maybe we can sort the MODELS_INFO: [
("_TZE200_9yapgbuv", "TS0601"),
("_TZE204_9yapgbuv", "TS0601"),
("_TZE200_cirvgep4", "TS0601"),
("_TZE200_upagmta9", "TS0601"),
("_TZE204_upagmta9", "TS0601"),
("_TZE200_utkemkbs", "TS0601"),
("_TZE204_utkemkbs", "TS0601"),
("_TZE200_yjjdcqsq", "TS0601"),
("_TZE204_yjjdcqsq", "TS0601"),
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@javicalle Some user reported that magic spells didn't made the device fully functional. |
I tried this on my local HA system, and the entity to change the temperature display units doesn't show up. My understanding is the unit does not send updates until the temperature units it set, instead it just runs the battery down trying to connect to Tuya. My unit therefore did not show any values and drained the battery. |
Added:
According to Z2M those are equivalents.
DP are compatible
https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/tuya.ts#L724
Sensors quirk are requested:
#2694
#2854
[edit]
Added EnchantedDevice to Device
Added TuyaEnchantableCluster to Temp cluster
Added tuya_spell_data_query = True to Device
as needed by
#2694 (comment)