Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version 3 of Ikea Frytur Blinds firmware 0x24040011 #2986

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

alvinchen1
Copy link

Proposed change

Since with firmware 0x24040011, IKEA introduced a new output cluster 3. (see #2418). This quirk adds the additional output clusters. I have tested and thanks to #2948, battery issues appear to also be resolved. Revised from #2984

Additional information

I haven't tested a new factory blind getting gets this or a later firmware update, getting this quirk and reports 2x the battery, but see #2418 for possible resolutions. My testing on devices with the firmware show correct battery and restore a minor annoyance where the shade being fully open will "drift" every so often leaving the shade slightly open.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (fc1e55f) to head (44cf181).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2986   +/-   ##
=======================================
  Coverage   87.85%   87.86%           
=======================================
  Files         301      301           
  Lines        9217     9220    +3     
=======================================
+ Hits         8098     8101    +3     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Collaborator

So, this firmware doesn't need battery percentage doubling, right? Since if this signature appears, it's always guaranteed to be a new firmware version.
The battery cluster will detect that too and just "do nothing", but if we can avoid using that cluster at all, we should.

If that cluster is removed, the quirk just doesn't do anything from what I can see. Like, no other clusters are patched.
So, what's the reason this is needed?

My testing on devices with the firmware show correct battery and restore a minor annoyance where the shade being fully open will "drift" every so often leaving the shade slightly open.

But the quirk does nothing to change this?

@TheJulianJES TheJulianJES marked this pull request as draft February 26, 2024 19:09
@alvinchen1
Copy link
Author

So I wondered about that as well and please forgive me if I am new and trying my first time at contributing. Let me see if I can explain better. What I found is that AFTER the firmware 0x24040011, none of the two original class quirks would apply.

class IkeaTradfriRollerBlinds (original)

    # input_clusters=[0, 1, 3, 4, 5, 32, 258, 4096, 64636]
    # output_clusters=[25, 4096]>

class IkeaTradfriRollerBlinds2 (original)

    # input_clusters=[0, 1, 3, 4, 5, 32, 258, 4096]
    # output_clusters=[25, 4096]>

class IkeaTradfriRollerBlinds3 (my contribution)

    # input_clusters=[0, 1, 3, 4, 5, 32, 258, 4096, 64636]
    # output_clusters=[3, 25, 4096]>

Having no quirk applied resulted in two problems (see #2418).

  1. Battery would double which was immediately apparent.
  2. Shade 100% open position would "drift" and not open completely. Then when shade would close it would be off by the same drift difference. This wouldn't happen immediately but over time. I'd say the course of one or three weeks, there would be anywhere from 1" to 2.5" difference when the shade was supposed to be 100% open. I have 20 of these shades so I definitely have a lot of data points. I would have to go around, pull the battery, wait, put it back in and the shade would reset to 100% closed, but over time, it would begin to drift again.

What I found is that when I wrote my custom quirk and tested with it, no longer get either the battery or the drift issue. When it set to open 100%, it does so perfectly and has for several months (testing since Nov 2023 see #2754). But you are correct, I don't see anything in the quirk itself which remedies this, I assumed (perhaps wrongly) that simply having a quirk was somehow fixing this since it always worked prior to firmware 0x24040011 when a quirk was applied and started working again once I wrote my custom quirk. Since both of my two problems appear fixed, I wanted to contribute it. Hope that makes more sense and answers your questions.

I believe the firmware still needs the same battery doubling, or at least in my testing, since battery doubling went in with PR 2948, it appears to still be working correctly. I know this because when I put in a fresh battery, it would show 200% if still a problem and it hasn't been doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants