Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immax NEO 07504L siren support #2978

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

cdalexndr
Copy link

@cdalexndr cdalexndr commented Feb 12, 2024

Proposed change

Immax NEO 07504L siren support

https://zigbee.blakadder.com/Immax_07504L.html

Tuya specs: https://developer.tuya.com/en/docs/iot/tuya-zigbee-warning-device-access-standard?id=K9ik6zvox5vkm

Additional information

UI Controls:
Siren activation works.
Default siren level works.
Default siren tone = not supported, how to disable this?
Default strobe works.
Default strobe level works.

zigbee command start_warning works

siren service works, but siren.turn_on volume only has two behaviors:

  • <1 (low)
  • =1 (medium)

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (0df6f2b) 87.72% compared to head (90fa3de) 87.50%.

Files Patch % Lines
zhaquirks/immax/ts0219_siren.py 39.53% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2978      +/-   ##
==========================================
- Coverage   87.72%   87.50%   -0.23%     
==========================================
  Files         298      299       +1     
  Lines        9119     9162      +43     
==========================================
+ Hits         8000     8017      +17     
- Misses       1119     1145      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant