Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zonnsmart TRV IDs and comment with names #2146

Merged
merged 1 commit into from Jan 28, 2023
Merged

Add Zonnsmart TRV IDs and comment with names #2146

merged 1 commit into from Jan 28, 2023

Conversation

MattWestb
Copy link
Contributor

And some names

@coveralls
Copy link

coveralls commented Jan 28, 2023 •
edited

Pull Request Test Coverage Report for Build 4033206673

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.702%
Totals Coverage Status
Change from base Build 4032940537: 0.0%
Covered Lines: 6887
Relevant Lines: 8228
💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023 •
edited

Codecov Report

Base: 83.70% // Head: 83.70% // No change to project coverage 👍

Coverage data is based on head (b3fd9c6) compared to base (07f38fc).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2146   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         258      258           
  Lines        8228     8228           
=======================================
  Hits         6887     6887           
  Misses       1341     1341
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_trv.py 81.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MattWestb
Copy link
Contributor Author

Looks being one pip problem and not the quirk.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jan 28, 2023
@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Jan 28, 2023 •
edited

Indeed. Will re-run once it's fixed (PyCQA/isort#2077 and PyCQA/isort#2078)

EDIT: Will need to rebase when #2147 is merged
EDIT: Rebased now.

@TheJulianJES TheJulianJES mentioned this pull request Jan 28, 2023
Merged
@TheJulianJES TheJulianJES changed the title Adding some Zonnsmart TRVs Add Zonnsmart TRVs IDs and comment with names Jan 28, 2023
@TheJulianJES TheJulianJES changed the title Add Zonnsmart TRVs IDs and comment with names Add Zonnsmart TRV IDs and comment with names Jan 28, 2023
@TheJulianJES TheJulianJES merged commit 9ec37e0 into zigpy:dev Jan 28, 2023
@MattWestb MattWestb deleted the patch-1 branch January 28, 2023 19:19
@MattWestb
Copy link
Contributor Author

Was "pre rebasing" :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJulianJES TheJulianJES TheJulianJES approved these changes

Assignees
No one assigned
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MattWestb @coveralls @codecov-commenter @TheJulianJES