Revert implementing 2nd argument for addChild #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-zicht
force-pushed
the
feature/revert-add-child-argument
branch
from
ada4cc9
to
42c89be
Compare
7ochem
approved these changes
Jun 8, 2020
7ochem
reviewed
Jan 19, 2022
| $pageDef->addMethodCall('addChild', [new Reference($contentItemServiceId), 'contentItems']); | ||
| $pageDef->addMethodCall('addChild', [new Reference($contentItemServiceId)]); |
There was a problem hiding this comment.
Nog iets dat ik tegenkwam in een project (en bij het fixen van sonata-project/SonataAdminBundle#7705) dat dat tweede argument dus de property in de child moet zijn waar de parent op gekoppeld is. Dus hier niet 'contentItems' (= children), maar 'page' (= de parent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #60