Skip to content

Fixes and improvements to v3 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Fixes and improvements to v3 #85

merged 8 commits into from
Feb 19, 2023

Conversation

bartosz347
Copy link
Contributor

I'm aware that it might not be a best approach to propose all changes at once, but my previous PR is waiting quite long and wanted to keep this project going.

Fixes/reverts to make v3 usable

New features

  • Defining custom message added to comment
  • Option to update the PR comment instead of creating a new one

oacik and others added 4 commits January 28, 2023 13:56

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@zgosalvez
Copy link
Owner

Hi! So sorry for missing out on people's issues and PRs! I'd like to confirm a few things:

@bartosz347
Copy link
Contributor Author

Hi, yes, both points are correct :)

@zgosalvez
Copy link
Owner

Cool! I'll clean up and review in the next few hours 🙂 I appreciate everyone's patience. 😅

@zgosalvez zgosalvez merged commit 53aba86 into zgosalvez:main Feb 19, 2023
@zgosalvez
Copy link
Owner

I'm not sure how we can avoid lcov-total from breaking the action again in the future. Feel free to build on #87, even just for catching the issue with ESM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants