circular dependency issue after switching to composer v2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to merge #8 before. |
partikus
force-pushed
the
composer2-compat
branch
from
e6d12b8
to
af11225
Compare
falkenhawk
reviewed
Jul 1, 2022
partikus
force-pushed
the
composer2-compat
branch
from
af11225
to
ada8ab8
Compare
falkenhawk
approved these changes
Jul 1, 2022
falkenhawk
added a commit
that referenced
this pull request
Nov 27, 2022
followup to #7 - make the fix platform-agnostic (i.e. unstuck `@runInSeparateProcess` tests on windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you run
vendor/bin/phpunitwith composer v2, then extra file (vendor/bin/phpunit) is being added to the autoloading list for tests with@runInSeparateProcessannotation.This PR introduce a change removing
**/bin/phpunitfrom the list.from sebastianbergmann/phpunit#4846
Composer 2.2 introduces some additional indirection for binaries to allow everyone to use custom PHP versions e.g. php7.4 vendor/bin/phpunit and ensure that vendor/phpunit/phpunit/phpunit is executed with php7.4 always (this previously worked only in cases/platforms where symlinks were supported).
References
composer/composer#10387 (comment)
sebastianbergmann#4846
Workaround
There is a way to avoid this change. We have to call
vendor/zf1s/phpunit/composer/bin/phpunitinstead ofvendor/bin/phpunit. I'm not sure if it's a good approach for switching to workaround. It might be confusing for others why there is a memory leak.