This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
[Bug] Fix Patient Search when patients have the same name #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor `ComboBoxOption` to use the full option value instead of just the label - Default `defaultValue` and `defaultSearchTerm` for `ComboBoxField` - Remove unused imports
Stephen-Tsen
requested review from
WesleyKapow,
mrosata,
luthfib and
melocule
🦋 Changeset detectedLatest commit: c161b56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Stephen-Tsen this may want to go into CTW repo instead! |
Stephen-Tsen
commented
Nov 22, 2023
| const option = e as ComboxboxFieldOption; | ||
| setSearchTerm(option.label); | ||
| setInputValue(option.value); | ||
| onCustomSelectChange?.(option); |
There was a problem hiding this comment.
Call the callback with the entire option object for backwards compatibility.
The plan is to apply this same fix to the next app/monorepo, and in there I will change this line to call the callback with just the option's value.
I'll apply a slightly modified version of this to the monorepo |
mrosata
previously approved these changes
Nov 22, 2023
mrosata
approved these changes
Nov 22, 2023
Stephen-Tsen
deleted the
CTW-1620-patient-search-does-not-navigate-to-correct-patient-if-multiple-patients-in-the-list-have-the-same-name
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket Number: CTW-1620
This PR fixes a bug in patient search when there are multiple patients with the same name. Previously the
ComboBoxOption's value was the label, which comprised the patient's full name. When an option was selected, theComboBoxFieldwould use the label to look up the first occurrence in the results, so if there are 2 or more patients with the same full name, it would always return the first patient.Now the
ComboBoxOption's value is the entire option so we can just return the option's value, which is theComboxboxFieldOptionobject, to theonCustomSelectChangecallback.How did you test it?
Manually tested in the demo app.
Manually tested with relative dependancies in standalone.
How will you know that this is working after deployment?
Manually test in all environments