Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented/access mgmt refactor #1972

Merged
merged 3 commits into from
May 17, 2024
Merged

Undocumented/access mgmt refactor #1972

merged 3 commits into from
May 17, 2024

Conversation

kaulfield23
Copy link
Contributor

@kaulfield23 kaulfield23 commented May 17, 2024 •
edited

Description

This PR refactors undocumented/access-management

Screenshots

Changes

  • Adds OfficialList.tsx
  • Changes variable,action names

Notes to reviewer

Related issues

Part of undocumented/access-management

@kaulfield23 kaulfield23 marked this pull request as draft May 17, 2024 09:23
@kaulfield23 kaulfield23 changed the base branch from main to undocumented/access-management May 17, 2024 09:23
@kaulfield23 kaulfield23 marked this pull request as ready for review May 17, 2024 09:25
rebecarubio
rebecarubio requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Amazing job renaming the actions too 💯 I just wondering if you can add the background color to follow the design in this PR? So then it's done!

@kaulfield23
Copy link
Contributor Author

Oh yesss! on it!

@kaulfield23
Copy link
Contributor Author

Looks like this now!

image

rebecarubio
rebecarubio approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we gooo 🚀

@kaulfield23 kaulfield23 merged commit 866fa6c into undocumented/access-management May 17, 2024
5 checks passed
@kaulfield23 kaulfield23 deleted the undocumented/access-mgmt-refactor branch May 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebecarubio rebecarubio rebecarubio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaulfield23 @rebecarubio