Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented/render tables #1964

Merged
merged 10 commits into from
May 16, 2024

Conversation

rebecarubio
Copy link
Contributor

Description

This PR renders the Administrators and Organizers tables in the Settings page.

Screenshots

image

Changes

  • Adds useRoles hook to get all the ZetkinOfficials users of the organization.
  • Adds RolesStore file to store the roles info.
  • Adds RolesList file to render the admin tables
  • Adds a RolesTable reusable component to define the admin tables

Notes to reviewer

WIP

Copy link
Contributor

@kaulfield23 kaulfield23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!! It looks so niiiiiicee! So good to see the tables with data 😄 I left comments for minor changes and left one for my curiosity!

src/features/settings/components/RolesList.tsx Outdated Show resolved Hide resolved
src/features/settings/components/RolesTable.tsx Outdated Show resolved Hide resolved
src/features/settings/components/RolesTable.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kaulfield23 kaulfield23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss let's gooooooo! 🦦 🐸 🐒

@kaulfield23 kaulfield23 merged commit 5e7b8fd into undocumented/access-management May 16, 2024
5 checks passed
@kaulfield23 kaulfield23 deleted the undocumented/render-tables branch May 16, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants