Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented/access-management #1959

Merged
merged 41 commits into from
May 27, 2024
Merged

Undocumented/access-management #1959

merged 41 commits into from
May 27, 2024

Conversation

kaulfield23
Copy link
Contributor

@kaulfield23 kaulfield23 commented May 15, 2024 •
edited

Description

This PR implements Settings page and its necessary functionalities. User can view the 'Administrator' / 'Organizer' list and demote, promote and remove official.

Screenshots

Mozilla.Firefox.2024-05-21.16-30-57.mp4

Changes

  • Adds OfficialList, RoleAddPersonButton
  • Adds hooks useRoles,useRolesMutations
  • Adds messages
  • Adds page for settings and SettingsLayout
  • Adds store for settings

Notes to reviewer

Related issues

Undocumented

@kaulfield23 kaulfield23 marked this pull request as draft May 15, 2024 09:14
@kaulfield23 kaulfield23 marked this pull request as ready for review May 22, 2024 07:00
richardolsson
richardolsson requested changes May 24, 2024
View reviewed changes
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this team! The feature is working great. I have tried the preview build and also looked at the code. I found some potential bugs in the code, but mostly I have a bunch of thoughts about naming.

Maybe @kaulfield23 can take a look at this?

src/zui/l10n/messageIds.ts Show resolved Hide resolved
src/features/settings/store.tsx Outdated Show resolved Hide resolved
src/core/store.ts Outdated Show resolved Hide resolved
src/features/breadcrumbs/l10n/messageIds.ts Show resolved Hide resolved
src/features/settings/store.tsx Outdated Show resolved Hide resolved
src/features/settings/rpc/getMembershipsList.tsx Outdated Show resolved Hide resolved
src/features/settings/rpc/updateNewRole.tsx Outdated Show resolved Hide resolved
src/features/settings/rpc/updateNewRole.tsx Outdated Show resolved Hide resolved
src/features/settings/l10n/messageIds.ts Outdated Show resolved Hide resolved
src/features/settings/components/RoleAddPersonButton.tsx Outdated Show resolved Hide resolved
richardolsson
richardolsson requested changes May 27, 2024
View reviewed changes
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I found a minor thing that I think we should improve before merging.

src/features/settings/rpc/getOfficialMemberships.tsx Show resolved Hide resolved
src/features/settings/rpc/setOfficialRole.tsx Outdated Show resolved Hide resolved
richardolsson
richardolsson approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks ready to merge to me. 💯

@kaulfield23 kaulfield23 merged commit 9104b5c into main May 27, 2024
5 checks passed
@kaulfield23 kaulfield23 deleted the undocumented/access-management branch May 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardolsson richardolsson richardolsson approved these changes

@ziggabyte ziggabyte Awaiting requested review from ziggabyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaulfield23 @richardolsson @rebecarubio