issue-1940/duplicated-events-in-calendar

[kaulfield23]

Description

This PR fixes a bug where changing dates of an event leaves duplicates in calendar

Screenshots

Calendar.Mozilla.Firefox.2024-05-10.10-37-19.mp4

Changes

• Adds more if statements

Notes to reviewer

Related issues

Resolves #1940

[awarn]

This seems to work for all I can tell!
Using the substring of the date as a key for the events does seem awkward (but presumably safe if we guarantee there is a always a start date value), though that is really a bigger question about "eventsByDate" than for this particular issue and pull request.

[ziggabyte]

Playing with this code works well!

In a conversation earlier today me and @richardolsson talked about the need for refactoring the addEventToState function. Reading these updates to the code I feel like it's still not "there" yet, but at the moment I can't really put my finger on what concrete feedback would make the code better 😅

So I have made comments on some more "cosmetic" things that I feel could make the code clearer, and maybe @richardolsson can add in if he feels that there are needs for other updates?

[kaulfield23]

Hmm merge conflicts! Will fix it today

[richardolsson]

I have looked at the code and the preview build and it's all looking good. Nice work!