-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Redirect to /organize - removed link buttons #1917
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Congrats on your first (I think???) PR!! :D
I've played with this both in the Vercel deploy and locally, and I think it works well! The only thing Iäm going to ask you to change is the order of the imports, so when that is fixed i can approve it!
@@ -6,6 +6,7 @@ export default makeMessages('core', { | |||
pageNotFound: m('Page not found'), | |||
}, | |||
home: { | |||
redirecting: m('Redirecting...'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Updated after code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soooo close, it's almost heart-breaking to ask for a change again 😂 but there are still some mis-sorted imports, I wrote the correct order in the comment, you can just copy that :)
import getUserMemberships from 'utils/getUserMemberships'; | ||
import { Msg } from 'core/i18n'; | ||
import Head from 'next/head'; | ||
import messageIds from 'core/l10n/messageIds'; | ||
import requiredEnvVar from 'utils/requiredEnvVar'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the order the imports should be in:
import { getIronSession } from 'iron-session';
import { GetServerSideProps } from 'next';
import Head from 'next/head';
import { useRouter } from 'next/router';
import { Container, Typography } from '@mui/material';
import { AppSession } from '../utils/types';
import getUserMemberships from 'utils/getUserMemberships';
import messageIds from 'core/l10n/messageIds';
import { Msg } from 'core/i18n';
import requiredEnvVar from 'utils/requiredEnvVar';
import { scaffold } from '../utils/next';
import { ZetkinUser } from '../utils/types/zetkin';
Description
This PR resolves #1826 by using a re-direct to locahost:3000/organize.
Screenshots
Changes
[Add a list of features added/changed, bugs fixed etc]
Adds…
Removes:
Notes to reviewer
Related issues
Resolves #1826